Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android + sync + cocoa fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 5 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void DoneRunOnMainThread() override {} 60 void DoneRunOnMainThread() override {}
61 61
62 private: 62 private:
63 ~HistoryEmptyTask() override {} 63 ~HistoryEmptyTask() override {}
64 64
65 base::WaitableEvent* done_; 65 base::WaitableEvent* done_;
66 }; 66 };
67 67
68 // Helper class used to wait for changes to take effect on the favicon of a 68 // Helper class used to wait for changes to take effect on the favicon of a
69 // particular bookmark node in a particular bookmark model. 69 // particular bookmark node in a particular bookmark model.
70 class FaviconChangeObserver : public BookmarkModelObserver { 70 class FaviconChangeObserver : public bookmarks::BookmarkModelObserver {
71 public: 71 public:
72 FaviconChangeObserver(BookmarkModel* model, const BookmarkNode* node) 72 FaviconChangeObserver(BookmarkModel* model, const BookmarkNode* node)
73 : model_(model), 73 : model_(model),
74 node_(node), 74 node_(node),
75 wait_for_load_(false) { 75 wait_for_load_(false) {
76 model->AddObserver(this); 76 model->AddObserver(this);
77 } 77 }
78 ~FaviconChangeObserver() override { model_->RemoveObserver(this); } 78 ~FaviconChangeObserver() override { model_->RemoveObserver(this); }
79 void WaitForGetFavicon() { 79 void WaitForGetFavicon() {
80 wait_for_load_ = true; 80 wait_for_load_ = true;
81 content::RunMessageLoop(); 81 content::RunMessageLoop();
82 ASSERT_TRUE(node_->is_favicon_loaded()); 82 ASSERT_TRUE(node_->is_favicon_loaded());
83 ASSERT_FALSE(model_->GetFavicon(node_).IsEmpty()); 83 ASSERT_FALSE(model_->GetFavicon(node_).IsEmpty());
84 } 84 }
85 void WaitForSetFavicon() { 85 void WaitForSetFavicon() {
86 wait_for_load_ = false; 86 wait_for_load_ = false;
87 content::RunMessageLoop(); 87 content::RunMessageLoop();
88 } 88 }
89
90 // bookmarks::BookmarkModelObserver:
89 void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override { 91 void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override {
90 } 92 }
91 void BookmarkNodeMoved(BookmarkModel* model, 93 void BookmarkNodeMoved(BookmarkModel* model,
92 const BookmarkNode* old_parent, 94 const BookmarkNode* old_parent,
93 int old_index, 95 int old_index,
94 const BookmarkNode* new_parent, 96 const BookmarkNode* new_parent,
95 int new_index) override {} 97 int new_index) override {}
96 void BookmarkNodeAdded(BookmarkModel* model, 98 void BookmarkNodeAdded(BookmarkModel* model,
97 const BookmarkNode* parent, 99 const BookmarkNode* parent,
98 int index) override {} 100 int index) override {}
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 832
831 std::string IndexedSubfolderName(int i) { 833 std::string IndexedSubfolderName(int i) {
832 return base::StringPrintf("Subfolder Name %d", i); 834 return base::StringPrintf("Subfolder Name %d", i);
833 } 835 }
834 836
835 std::string IndexedSubsubfolderName(int i) { 837 std::string IndexedSubsubfolderName(int i) {
836 return base::StringPrintf("Subsubfolder Name %d", i); 838 return base::StringPrintf("Subsubfolder Name %d", i);
837 } 839 }
838 840
839 } // namespace bookmarks_helper 841 } // namespace bookmarks_helper
OLDNEW
« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.h ('k') | chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698