chrome/browser/sync/glue/bookmark_change_processor.h - Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.h

Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android + sync + cocoa fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmarks_api.h ('k') | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/bookmark_change_processor.h

diff --git a/chrome/browser/sync/glue/bookmark_change_processor.h b/chrome/browser/sync/glue/bookmark_change_processor.h

index ff0605f996888e79da2936bb2cf11c2a12ce24dc..a882eb37f9f64b6dccebbf693ce943ba9a6edade 100644

--- a/chrome/browser/sync/glue/bookmark_change_processor.h

+++ b/chrome/browser/sync/glue/bookmark_change_processor.h

@@ -32,7 +32,7 @@ namespace browser_sync {

// and applying them to the sync API 'syncable' model, and vice versa.

// All operations and use of this class are from the UI thread.

// This is currently bookmarks specific.

-class BookmarkChangeProcessor : public BookmarkModelObserver,

+class BookmarkChangeProcessor : public bookmarks::BookmarkModelObserver,

public sync_driver::ChangeProcessor {

public:

BookmarkChangeProcessor(Profile* profile,

@@ -40,7 +40,7 @@ class BookmarkChangeProcessor : public BookmarkModelObserver,

sync_driver::DataTypeErrorHandler* error_handler);

~BookmarkChangeProcessor() override;

- // BookmarkModelObserver implementation.

+ // bookmarks::BookmarkModelObserver:

// BookmarkModel -> sync API model change application.

void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;

void BookmarkModelBeingDeleted(BookmarkModel* model) override;