Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791623004: bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, sdefresne, blundell, nshaik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Move BookmarkModelObserver into 'bookmarks' namespace. BUG=370433 TEST=unit_tests, components_unittests R=sky@chromium.org Committed: https://crrev.com/ea7453d32e869b67effb6c11a01931887daed4a7 Cr-Commit-Position: refs/heads/master@{#308577}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : android + sync + cocoa fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -26 lines) Patch
M chrome/browser/android/provider/bookmark_model_observer_task.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_model_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_image_service.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
6 years ago (2014-12-12 22:36:27 UTC) #1
sky
LGTM
6 years ago (2014-12-15 15:49:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791623004/60001
6 years ago (2014-12-16 13:07:43 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-16 13:55:50 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-16 13:56:36 UTC) #6
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ea7453d32e869b67effb6c11a01931887daed4a7
Cr-Commit-Position: refs/heads/master@{#308577}

Powered by Google App Engine
This is Rietveld 408576698