https://codereview.chromium.org/79123004/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h File content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h (right): https://codereview.chromium.org/79123004/diff/1/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h#newcode665 content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h:665: FAIL_IF_MAJOR_PERF_CAVEAT = 0x10002 Can you also implement this in ...
6 years, 11 months ago
(2013-11-20 22:44:54 UTC)
#3
LGTM with nits https://codereview.chromium.org/79123004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/79123004/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode2288 gpu/command_buffer/service/gles2_cmd_decoder.cc:2288: if (command_line->HasSwitch(switches::kUseGL)) { You don't have ...
6 years, 11 months ago
(2013-11-20 22:44:56 UTC)
#4
On 2013/11/20 22:39:01, Ken Russell wrote: > This duplication of constants is really unfortunate. Is ...
6 years, 11 months ago
(2013-11-22 22:16:32 UTC)
#5
On 2013/11/20 22:39:01, Ken Russell wrote:
> This duplication of constants is really unfortunate. Is there no way to share
> the definitions with
> content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h ? If not,
> please at least put a comment here and in
> webgraphicscontext3d_command_buffer_impl.h about keeping the values in sync.
Completely agree. I put the comment in place, and spent some time looking at
what it's going to take to
normalize the enums here. Unfortunately it's something that would quickly
balloon outside the scope of this
ticket, but I'd like to do it separately.
Logged as http://crbug.com/322699
> How has this been tested?
Patchset #1 was tested on my Windows box with a full Chrome (not Chromium)
build. Aggravatingly I have not been able to test the more recent patchset
because of issues building, which I a continuing to work on. The code is posted
for feedback only.
Automatic testing of this feature is difficult, since swiftshader is only
available in official builds.
On 2013/11/20 22:44:54, piman wrote:
> Can you also implement this in the in-process context, in
> webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.*
Done, and thanks for pointing out that it was needed.
> Can we move the logic about "is this swiftshader" into the feature_info.cc,
> maybe even feeding this through the bug/workarounds blacklist?
Done, and better for it. Thanks.
On 2013/11/20 22:44:56, Zhenyao Mo wrote:
> Also, why don't we move this and the attrib_parser to the top of the function?
> so we don't waste work if it's swiftshader.
Done.
Ken Russell (switch to Gerrit)
LGTM with the following comments addressed and if this has been tested manually. It would ...
6 years, 11 months ago
(2013-11-23 03:07:03 UTC)
#6
Issue 79123004: Implemented failIfMajorPerformanceCaveat WebGL context creation attribute.
(Closed)
Created 6 years, 11 months ago by bajones
Modified 6 years, 11 months ago
Reviewers: Ken Russell (switch to Gerrit), piman, Zhenyao Mo
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 7
Chromium Code Reviews
