Implemented failIfMajorPerformanceCaveat WebGL context creation attribute.

gpu/command_buffer/common/gles2_cmd_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is here so other GLES2 related files can have a common set of
 // includes where appropriate.
 
 #include <stdio.h>
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 716 matching lines @@
 const int32 kSamples         = 0x3031;  // EGL_SAMPLES
 const int32 kSampleBuffers   = 0x3032;  // EGL_SAMPLE_BUFFERS
 const int32 kNone            = 0x3038;  // EGL_NONE
 const int32 kSwapBehavior    = 0x3093;  // EGL_SWAP_BEHAVIOR
 const int32 kBufferPreserved = 0x3094;  // EGL_BUFFER_PRESERVED
 const int32 kBufferDestroyed = 0x3095;  // EGL_BUFFER_DESTROYED
 
 // Chromium only.
 const int32 kShareResources        = 0x10000;
 const int32 kBindGeneratesResource = 0x10001;
+const int32 kFailIfMajorPerfCaveat = 0x10002;

[Ken Russell (switch to Gerrit), 2013/11/20 22:39:02]

This duplication of constants is really unfortunate. Is there no way to share
the definitions with
content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h ? If not,
please at least put a comment here and in
webgraphicscontext3d_command_buffer_impl.h about keeping the values in sync.

 
 }  // namespace
 
 ContextCreationAttribHelper::ContextCreationAttribHelper()
   : alpha_size_(-1),
     blue_size_(-1),
     green_size_(-1),
     red_size_(-1),
     depth_size_(-1),
     stencil_size_(-1),
     samples_(-1),
     sample_buffers_(-1),
     buffer_preserved_(true),
     share_resources_(false),
-    bind_generates_resource_(true) {
+    bind_generates_resource_(true),
+    fail_if_major_perf_caveat_(false) {
 }
 
 void ContextCreationAttribHelper::Serialize(std::vector<int32>* attribs) {
   if (alpha_size_ != -1) {
     attribs->push_back(kAlphaSize);
     attribs->push_back(alpha_size_);
   }
   if (blue_size_ != -1) {
     attribs->push_back(kBlueSize);
     attribs->push_back(blue_size_);
@@ skipping 21 matching lines @@
   if (sample_buffers_ != -1) {
     attribs->push_back(kSampleBuffers);
     attribs->push_back(sample_buffers_);
   }
   attribs->push_back(kSwapBehavior);
   attribs->push_back(buffer_preserved_ ? kBufferPreserved : kBufferDestroyed);
   attribs->push_back(kShareResources);
   attribs->push_back(share_resources_ ? 1 : 0);
   attribs->push_back(kBindGeneratesResource);
   attribs->push_back(bind_generates_resource_ ? 1 : 0);
+  attribs->push_back(kFailIfMajorPerfCaveat);
+  attribs->push_back(fail_if_major_perf_caveat_ ? 1 : 0);
   attribs->push_back(kNone);
 }
 
 bool ContextCreationAttribHelper::Parse(const std::vector<int32>& attribs) {
   for (size_t i = 0; i < attribs.size(); i += 2) {
     const int32 attrib = attribs[i];
     if (i + 1 >= attribs.size()) {
       if (attrib == kNone) {
         return true;
       }
@@ skipping 31 matching lines @@
         break;
       case kSwapBehavior:
         buffer_preserved_ = value == kBufferPreserved;
         break;
       case kShareResources:
         share_resources_ = value != 0;
         break;
       case kBindGeneratesResource:
         bind_generates_resource_ = value != 0;
         break;
+      case kFailIfMajorPerfCaveat:
+        fail_if_major_perf_caveat_ = value != 0;
+        break;
       case kNone:
         // Terminate list, even if more attributes.
         return true;
       default:
         DLOG(ERROR) << "Invalid context creation attribute: " << attrib;
         return false;
     }
   }
 
   return true;
 }
 
 #include "gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu