Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 79123004: Implemented failIfMajorPerformanceCaveat WebGL context creation attribute. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More comments, logging updates Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
index a8af08a8811dcad20a6c49dae2e505110fd46aef..898fb8d8c2a6a49c06377378ea2a5d89f52f7969 100644
--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h
@@ -648,6 +648,9 @@ class WebGraphicsContext3DCommandBufferImpl
// the 16-bit range are the same as used by EGL. Those outside the 16-bit
// range are unique to Chromium. Attributes are matched using a closest fit
// algorithm.
+ // Changes to this enum should also be copied to
+ // gpu/command_buffer/common/gles2_cmd_utils.cc and to
+ // gpu/command_buffer/client/gl_in_process_context.cc
enum Attribute {
ALPHA_SIZE = 0x3021,
BLUE_SIZE = 0x3022,
@@ -661,7 +664,8 @@ class WebGraphicsContext3DCommandBufferImpl
WIDTH = 0x3057,
NONE = 0x3038, // Attrib list = terminator
SHARE_RESOURCES = 0x10000,
- BIND_GENERATES_RESOURCES = 0x10001
+ BIND_GENERATES_RESOURCES = 0x10001,
+ FAIL_IF_MAJOR_PERF_CAVEAT = 0x10002
};
friend class WebGraphicsContext3DErrorMessageCallback;
« no previous file with comments | « no previous file | content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698