Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786293002: Rename CustomCoordTextureEffect to GrBitmapTextGeoProc. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Rename CustomCoordTextureEffect to GrBitmapTextGeoProc. Also add in explicit set for LCD text in invariantOutput. BUG=skia: Committed: https://skia.googlesource.com/skia/+/309e346744f57fadd66ba3c2f14875c86311682e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -243 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrInvariantOutput.h View 1 4 chunks +22 lines, -9 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + src/gpu/effects/GrBitmapTextGeoProc.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 6 chunks +26 lines, -27 lines 0 comments Download
D src/gpu/effects/GrCustomCoordsTextureEffect.h View 1 chunk +0 lines, -59 lines 0 comments Download
D src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
6 years ago (2014-12-09 17:36:41 UTC) #2
bsalomon
lgtm w/ some naming and comment requests https://codereview.chromium.org/786293002/diff/1/include/gpu/GrInvariantOutput.h File include/gpu/GrInvariantOutput.h (right): https://codereview.chromium.org/786293002/diff/1/include/gpu/GrInvariantOutput.h#newcode95 include/gpu/GrInvariantOutput.h:95: // Temporary ...
6 years ago (2014-12-09 18:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786293002/20001
6 years ago (2014-12-09 18:23:40 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-09 18:36:03 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/309e346744f57fadd66ba3c2f14875c86311682e

Powered by Google App Engine
This is Rietveld 408576698