net: Rename URLRequestStatus::os_error_.

net: Rename URLRequestStatus::os_error_.

BUG=92264
TEST=None

R=willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100136

[willchan no longer on Chromium, 2011-09-07 23:44:36]

Sending to Chris in case he has time to get to this before me.

[cbentzel, 2011-09-08 01:35:00]

LGTM, assuming the following things are fixed.

I didn't realize that Will had entered a bug about this - it is a nice cleanup!

http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/http_post_provider_interface.h (right):

http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/http_post_provider_interface.h:41: // error()
may be non-zero and hence contain more information.
This is probably incorrect - I'm guessing os_error relates to the os_error_code
argument.

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
net/url_request/url_request_unittest.cc:907: (int) r.status().status() << ", os
error: " << r.status().error();
Change ", os error: "

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
net/url_request/url_request_unittest.cc:954: (int) r.status().status() << ", os
error: " << r.status().error();
Change ", os error: "

[willchan no longer on Chromium, 2011-09-08 01:46:39]

Rubberstamp LGTM for chrome/browser/net/, thanks Chris!

On Wed, Sep 7, 2011 at 6:35 PM,  <cbentzel@chromium.org> wrote:
> LGTM, assuming the following things are fixed.
>
> I didn't realize that Will had entered a bug about this - it is a nice
> cleanup!
>
>
>
http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
> File chrome/browser/sync/internal_api/http_post_provider_interface.h
> (right):
>
>
http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
> chrome/browser/sync/internal_api/http_post_provider_interface.h:41: //
> error() may be non-zero and hence contain more information.
> This is probably incorrect - I'm guessing os_error relates to the
> os_error_code argument.
>
>
http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
> File net/url_request/url_request_unittest.cc (right):
>
>
http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
> net/url_request/url_request_unittest.cc:907: (int) r.status().status()
> << ", os error: " << r.status().error();
> Change ", os error: "
>
>
http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
> net/url_request/url_request_unittest.cc:954: (int) r.status().status()
> << ", os error: " << r.status().error();
> Change ", os error: "
>
> http://codereview.chromium.org/7846007/
>

[tfarina, 2011-09-08 11:19:26]

http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
File chrome/browser/sync/internal_api/http_post_provider_interface.h (right):

http://codereview.chromium.org/7846007/diff/5036/chrome/browser/sync/internal...
chrome/browser/sync/internal_api/http_post_provider_interface.h:41: // error()
may be non-zero and hence contain more information.
On 2011/09/08 01:35:01, cbentzel wrote:
> This is probably incorrect - I'm guessing os_error relates to the
os_error_code
> argument.

Done.

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
net/url_request/url_request_unittest.cc:907: (int) r.status().status() << ", os
error: " << r.status().error();
On 2011/09/08 01:35:01, cbentzel wrote:
> Change ", os error: "

Done.

http://codereview.chromium.org/7846007/diff/5036/net/url_request/url_request_...
net/url_request/url_request_unittest.cc:954: (int) r.status().status() << ", os
error: " << r.status().error();
On 2011/09/08 01:35:01, cbentzel wrote:
> Change ", os error: "

Done.