Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: net/url_request/url_request_status.h

Issue 7846007: net: Rename URLRequestStatus::os_error_. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix os_error_code Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file's dependencies should be kept to a minimum so that it can be 5 // This file's dependencies should be kept to a minimum so that it can be
6 // included in WebKit code that doesn't rely on much of common. 6 // included in WebKit code that doesn't rely on much of common.
7 7
8 #ifndef NET_URL_REQUEST_URL_REQUEST_STATUS_H_ 8 #ifndef NET_URL_REQUEST_URL_REQUEST_STATUS_H_
9 #define NET_URL_REQUEST_URL_REQUEST_STATUS_H_ 9 #define NET_URL_REQUEST_URL_REQUEST_STATUS_H_
10 #pragma once 10 #pragma once
11 11
12 namespace net { 12 namespace net {
13 13
14 // Represents the result of a URL request. It encodes errors and various 14 // Represents the result of a URL request. It encodes errors and various
15 // types of success. 15 // types of success.
16 class URLRequestStatus { 16 class URLRequestStatus {
17 public: 17 public:
18 enum Status { 18 enum Status {
19 // Request succeeded, os_error() will be 0. 19 // Request succeeded, |error_| will be 0.
20 SUCCESS = 0, 20 SUCCESS = 0,
21 21
22 // An IO request is pending, and the caller will be informed when it is 22 // An IO request is pending, and the caller will be informed when it is
23 // completed. 23 // completed.
24 IO_PENDING, 24 IO_PENDING,
25 25
26 // Request was successful but was handled by an external program, so there 26 // Request was successful but was handled by an external program, so there
27 // is no response data. This usually means the current page should not be 27 // is no response data. This usually means the current page should not be
28 // navigated, but no error should be displayed. os_error will be 0. 28 // navigated, but no error should be displayed. |error_| will be 0.
29 HANDLED_EXTERNALLY, 29 HANDLED_EXTERNALLY,
30 30
31 // Request was cancelled programatically. 31 // Request was cancelled programatically.
32 CANCELED, 32 CANCELED,
33 33
34 // The request failed for some reason. os_error may have more information. 34 // The request failed for some reason. |error_| may have more information.
35 FAILED, 35 FAILED,
36 }; 36 };
37 37
38 URLRequestStatus() : status_(SUCCESS), os_error_(0) {} 38 URLRequestStatus() : status_(SUCCESS), error_(0) {}
39 URLRequestStatus(Status s, int e) : status_(s), os_error_(e) {} 39 URLRequestStatus(Status s, int e) : status_(s), error_(e) {}
40 40
41 Status status() const { return status_; } 41 Status status() const { return status_; }
42 void set_status(Status s) { status_ = s; } 42 void set_status(Status s) { status_ = s; }
43 43
44 int os_error() const { return os_error_; } 44 int error() const { return error_; }
45 void set_os_error(int e) { os_error_ = e; } 45 void set_error(int e) { error_ = e; }
46 46
47 // Returns true if the status is success, which makes some calling code more 47 // Returns true if the status is success, which makes some calling code more
48 // convenient because this is the most common test. Note that we do NOT treat 48 // convenient because this is the most common test. Note that we do NOT treat
49 // HANDLED_EXTERNALLY as success. For everything except user notifications, 49 // HANDLED_EXTERNALLY as success. For everything except user notifications,
50 // this value should be handled like an error (processing should stop). 50 // this value should be handled like an error (processing should stop).
51 bool is_success() const { 51 bool is_success() const {
52 return status_ == SUCCESS || status_ == IO_PENDING; 52 return status_ == SUCCESS || status_ == IO_PENDING;
53 } 53 }
54 54
55 // Returns true if the request is waiting for IO. 55 // Returns true if the request is waiting for IO.
56 bool is_io_pending() const { 56 bool is_io_pending() const {
57 return status_ == IO_PENDING; 57 return status_ == IO_PENDING;
58 } 58 }
59 59
60 private: 60 private:
61 // Application level status 61 // Application level status.
62 Status status_; 62 Status status_;
63 63
64 // Error code from the operating system network layer if an error was 64 // Error code from the network layer if an error was encountered.
65 // encountered 65 int error_;
66 int os_error_;
67 }; 66 };
68 67
69 } // namespace net 68 } // namespace net
70 69
71 #endif // NET_URL_REQUEST_URL_REQUEST_STATUS_H_ 70 #endif // NET_URL_REQUEST_URL_REQUEST_STATUS_H_
OLDNEW
« no previous file with comments | « net/url_request/url_request_job_factory_unittest.cc ('k') | net/url_request/url_request_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698