net/url_request/url_request_job_factory_unittest.cc - Issue 7846007: net: Rename URLRequestStatus::os_error_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory_unittest.cc

Issue 7846007: net: Rename URLRequestStatus::os_error_. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix os_error_code Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_job_factory_unittest.cc

diff --git a/net/url_request/url_request_job_factory_unittest.cc b/net/url_request/url_request_job_factory_unittest.cc

index d29d1e080d92e644a1c33afd7ac5cab3b92da7fa..56b1a5616f84f93dbd9400d36c26cb2e30a127e7 100644

--- a/net/url_request/url_request_job_factory_unittest.cc

+++ b/net/url_request/url_request_job_factory_unittest.cc

@@ -88,7 +88,7 @@ TEST(URLRequestJobFactoryTest, NoProtocolHandler) {

MessageLoop::current()->Run();

EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());

- EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().os_error());

+ EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().error());

}

TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {

@@ -103,7 +103,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {

MessageLoop::current()->Run();

EXPECT_EQ(URLRequestStatus::SUCCESS, request.status().status());

- EXPECT_EQ(OK, request.status().os_error());

+ EXPECT_EQ(OK, request.status().error());

}

TEST(URLRequestJobFactoryTest, DeleteProtocolHandler) {

@@ -126,7 +126,7 @@ TEST(URLRequestJobFactoryTest, BasicInterceptor) {

MessageLoop::current()->Run();

EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());

- EXPECT_EQ(ERR_FAILED, request.status().os_error());

+ EXPECT_EQ(ERR_FAILED, request.status().error());

}

TEST(URLRequestJobFactoryTest, InterceptorNeedsValidSchemeStill) {

@@ -141,7 +141,7 @@ TEST(URLRequestJobFactoryTest, InterceptorNeedsValidSchemeStill) {

MessageLoop::current()->Run();

EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());

- EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().os_error());

+ EXPECT_EQ(ERR_UNKNOWN_URL_SCHEME, request.status().error());

}

TEST(URLRequestJobFactoryTest, InterceptorOverridesProtocolHandler) {

@@ -157,7 +157,7 @@ TEST(URLRequestJobFactoryTest, InterceptorOverridesProtocolHandler) {

MessageLoop::current()->Run();

EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());

- EXPECT_EQ(ERR_FAILED, request.status().os_error());

+ EXPECT_EQ(ERR_FAILED, request.status().error());

}

TEST(URLRequestJobFactoryTest, InterceptorDoesntInterceptUnknownProtocols) {

@@ -190,7 +190,7 @@ TEST(URLRequestJobFactoryTest, InterceptorInterceptsHandledUnknownProtocols) {

MessageLoop::current()->Run();

EXPECT_TRUE(interceptor->did_intercept_);

EXPECT_EQ(URLRequestStatus::FAILED, request.status().status());

- EXPECT_EQ(ERR_FAILED, request.status().os_error());

+ EXPECT_EQ(ERR_FAILED, request.status().error());

}

TEST(URLRequestJobFactoryTest, InterceptorAffectsIsHandledProtocol) {

« no previous file with comments | « net/url_request/url_request_job.cc ('k') | net/url_request/url_request_status.h » ('j') | no next file with comments »