Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers}

Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers}

- Add ExtendableEventInit. This is the parent dictionary of following
  event inits: NotificationEventInit, PushEventInit, and InstallEventInit.
- Replaces manually-written NotificationEventInit, PushEventInit, and
  InstallEventInit with IDL dictionaries.
- Add tests.

BUG=433179
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186746

[bashi, 2014-12-05 00:36:47]

Patchset #1 (id:1) has been deleted

[bashi, 2014-12-05 01:45:10]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, horo@chromium.org, peter@chromium.org

[bashi, 2014-12-05 01:45:11]

peter@, could you take a look at notifications and push_messaging?
horo@, could you take a look at serviceworkers?
haraken@, could you take a look?

[haraken, 2014-12-05 02:26:27]

LGTM

[Peter Beverloo, 2014-12-05 15:48:33]

lgtm for push and notifications. Rest LG as well.

Thanks for doing this refactoring!

https://codereview.chromium.org/780963004/diff/20001/Source/modules/notificat...
File Source/modules/notifications/NotificationEvent.idl (right):

https://codereview.chromium.org/780963004/diff/20001/Source/modules/notificat...
Source/modules/notifications/NotificationEvent.idl:11: Constructor(DOMString
type, optional NotificationEventInit eventInitDict),
nit: Many new IDL files are trying to keep the list of interface-level
annotations ordered by alphabet, is there any reason for moving Constructor() to
be the last annotation?

https://codereview.chromium.org/780963004/diff/20001/Source/modules/push_mess...
File Source/modules/push_messaging/PushEventInit.idl (right):

https://codereview.chromium.org/780963004/diff/20001/Source/modules/push_mess...
Source/modules/push_messaging/PushEventInit.idl:9: //
https://w3c.github.io/push-api/#idl-def-PushMessageData
Could you remove this FIXME? The spec is wrong and mvanouwerkerk still has to
update it :-).

[horo, 2014-12-05 20:34:07]

lgtm

[bashi, 2014-12-08 23:39:29]

Thank you for reviews!

https://codereview.chromium.org/780963004/diff/20001/Source/modules/notificat...
File Source/modules/notifications/NotificationEvent.idl (right):

https://codereview.chromium.org/780963004/diff/20001/Source/modules/notificat...
Source/modules/notifications/NotificationEvent.idl:11: Constructor(DOMString
type, optional NotificationEventInit eventInitDict),
On 2014/12/05 15:48:33, Peter Beverloo wrote:
> nit: Many new IDL files are trying to keep the list of interface-level
> annotations ordered by alphabet, is there any reason for moving Constructor()
to
> be the last annotation?

Ah, I didn't know that. Done. Thanks!

https://codereview.chromium.org/780963004/diff/20001/Source/modules/push_mess...
File Source/modules/push_messaging/PushEventInit.idl (right):

https://codereview.chromium.org/780963004/diff/20001/Source/modules/push_mess...
Source/modules/push_messaging/PushEventInit.idl:9: //
https://w3c.github.io/push-api/#idl-def-PushMessageData
On 2014/12/05 15:48:33, Peter Beverloo wrote:
> Could you remove this FIXME? The spec is wrong and mvanouwerkerk still has to
> update it :-).

Done. Thank you for the clarification :)

[bashi, 2014-12-08 23:39:38]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-12-08 23:40:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780963004/60001

[commit-bot: I haz the power, 2014-12-09 01:08:05]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186746