Source/modules/notifications/NotificationEvent.idl - Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers}

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/notifications/NotificationEvent.idl

Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/notifications/NotificationEvent.cpp ('k') | Source/modules/notifications/NotificationEventInit.idl » ('j') | Source/modules/push_messaging/PushEventInit.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://notifications.spec.whatwg.org/#service-worker-api	5 // https://notifications.spec.whatwg.org/#service-worker-api

6	6

7 [	7 [

8 EventConstructor,

9 Exposed=ServiceWorker,	8 Exposed=ServiceWorker,

10 RuntimeEnabled=ServiceWorkerNotifications,	9 RuntimeEnabled=ServiceWorkerNotifications,

11 TypeChecking=Interface,	10 TypeChecking=Interface,

	11 Constructor(DOMString type, optional NotificationEventInit eventInitDict),
	Peter Beverloo 2014/12/05 15:48:33 nit: Many new IDL files are trying to keep the lis nit: Many new IDL files are trying to keep the list of interface-level annotations ordered by alphabet, is there any reason for moving Constructor() to be the last annotation? bashi 2014/12/08 23:39:29 Ah, I didn't know that. Done. Thanks! Show quoted text On 2014/12/05 15:48:33, Peter Beverloo wrote: > nit: Many new IDL files are trying to keep the list of interface-level > annotations ordered by alphabet, is there any reason for moving Constructor() to > be the last annotation? Ah, I didn't know that. Done. Thanks!
12 ] interface NotificationEvent : ExtendableEvent {	12 ] interface NotificationEvent : ExtendableEvent {

13 readonly attribute Notification notification;	13 readonly attribute Notification notification;

14 };	14 };

OLD	NEW