Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2246)

Unified Diff: Source/modules/push_messaging/PushEvent.cpp

Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushEvent.cpp
diff --git a/Source/modules/push_messaging/PushEvent.cpp b/Source/modules/push_messaging/PushEvent.cpp
index 06dbc4676297cecd0d74da6b8a5ce2cd0e4edb87..5c0d4d03b8c5492ef38bab3a77114298c0693649 100644
--- a/Source/modules/push_messaging/PushEvent.cpp
+++ b/Source/modules/push_messaging/PushEvent.cpp
@@ -7,10 +7,6 @@
namespace blink {
-PushEventInit::PushEventInit()
-{
-}
-
PushEvent::PushEvent()
{
}
@@ -23,8 +19,9 @@ PushEvent::PushEvent(const AtomicString& type, PushMessageData* data, WaitUntilO
PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer)
: ExtendableEvent(type, initializer)
- , m_data(initializer.data)
{
+ if (initializer.hasData())
+ m_data = initializer.data();
}
PushEvent::~PushEvent()
« no previous file with comments | « Source/modules/push_messaging/PushEvent.h ('k') | Source/modules/push_messaging/PushEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698