Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead. TBR=sgurun@chromium.org BUG=439551, 439620 Committed: https://crrev.com/19ece1e4af5207b92c2152395dfccca1683504e1 Cr-Commit-Position: refs/heads/master@{#307128}

Patch Set 1 #

Total comments: 2

Patch Set 2 : static-ify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -82 lines) Patch
M android_webview/native/aw_autofill_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate_unittest.cc View 1 4 chunks +30 lines, -51 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_client.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/test_autofill_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Evan Stade
6 years ago (2014-12-05 22:24:22 UTC) #2
Ilya Sherman
https://codereview.chromium.org/780423002/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc File chrome/browser/autofill/autofill_cc_infobar_delegate.cc (left): https://codereview.chromium.org/780423002/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc#oldcode53 chrome/browser/autofill/autofill_cc_infobar_delegate.cc:53: metric_logger_->LogCreditCardInfoBarMetric(user_action); Rather than breaking the metrics, let's just make ...
6 years ago (2014-12-05 22:58:54 UTC) #3
Evan Stade
https://codereview.chromium.org/780423002/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc File chrome/browser/autofill/autofill_cc_infobar_delegate.cc (left): https://codereview.chromium.org/780423002/diff/1/chrome/browser/autofill/autofill_cc_infobar_delegate.cc#oldcode53 chrome/browser/autofill/autofill_cc_infobar_delegate.cc:53: metric_logger_->LogCreditCardInfoBarMetric(user_action); On 2014/12/05 22:58:54, Ilya Sherman wrote: > Rather ...
6 years ago (2014-12-05 23:42:47 UTC) #4
Ilya Sherman
LGTM, thanks.
6 years ago (2014-12-05 23:52:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780423002/20001
6 years ago (2014-12-05 23:55:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-06 00:49:02 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/19ece1e4af5207b92c2152395dfccca1683504e1 Cr-Commit-Position: refs/heads/master@{#307128}
6 years ago (2014-12-06 00:49:45 UTC) #9
gab
6 years ago (2014-12-08 19:22:10 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/790543002/ by gab@chromium.org.

The reason for reverting is: Suspected cause of flakines on Win7-bots, see
http://crbug.com/440060 for details..

Powered by Google App Engine
This is Rietveld 408576698