android_webview/native/aw_autofill_client.h - Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/native/aw_autofill_client.h

Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: static-ify Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | android_webview/native/aw_autofill_client.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_	5 #ifndef ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_

6 #define ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_	6 #define ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 bool GetSaveFormData();	55 bool GetSaveFormData();

56	56

57 // AutofillClient:	57 // AutofillClient:

58 virtual autofill::PersonalDataManager* GetPersonalDataManager() override;	58 virtual autofill::PersonalDataManager* GetPersonalDataManager() override;

59 virtual scoped_refptr<autofill::AutofillWebDataService> GetDatabase()	59 virtual scoped_refptr<autofill::AutofillWebDataService> GetDatabase()

60 override;	60 override;

61 virtual PrefService* GetPrefs() override;	61 virtual PrefService* GetPrefs() override;

62 virtual void HideRequestAutocompleteDialog() override;	62 virtual void HideRequestAutocompleteDialog() override;

63 virtual void ShowAutofillSettings() override;	63 virtual void ShowAutofillSettings() override;

64 virtual void ConfirmSaveCreditCard(	64 virtual void ConfirmSaveCreditCard(

65 const autofill::AutofillMetrics& metric_logger,

66 const base::Closure& save_card_callback) override;	65 const base::Closure& save_card_callback) override;

67 virtual bool HasCreditCardScanFeature() override;	66 virtual bool HasCreditCardScanFeature() override;

68 virtual void ScanCreditCard(const CreditCardScanCallback& callback) override;	67 virtual void ScanCreditCard(const CreditCardScanCallback& callback) override;

69 virtual void ShowRequestAutocompleteDialog(	68 virtual void ShowRequestAutocompleteDialog(

70 const autofill::FormData& form,	69 const autofill::FormData& form,

71 const GURL& source_url,	70 const GURL& source_url,

72 const ResultCallback& callback) override;	71 const ResultCallback& callback) override;

73 virtual void ShowAutofillPopup(	72 virtual void ShowAutofillPopup(

74 const gfx::RectF& element_bounds,	73 const gfx::RectF& element_bounds,

75 base::i18n::TextDirection text_direction,	74 base::i18n::TextDirection text_direction,

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
114 base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;	113 base::WeakPtr<autofill::AutofillPopupDelegate> delegate_;

115	114

116 DISALLOW_COPY_AND_ASSIGN(AwAutofillClient);	115 DISALLOW_COPY_AND_ASSIGN(AwAutofillClient);

117 };	116 };

118	117

119 bool RegisterAwAutofillClient(JNIEnv* env);	118 bool RegisterAwAutofillClient(JNIEnv* env);

120	119

121 } // namespace android_webview	120 } // namespace android_webview

122	121

123 #endif // ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_	122 #endif // ANDROID_WEBVIEW_NATIVE_AW_AUTOFILL_CLIENT_H_

OLD	NEW