components/autofill/core/browser/autofill_metrics.h - Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: static-ify Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_metrics.h

diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h

index 68fb824df60a530f396d8b095f850b7da1a0f0d3..b02d339e7e1b7c18a304950621455a8d0a3db40a 100644

--- a/components/autofill/core/browser/autofill_metrics.h

+++ b/components/autofill/core/browser/autofill_metrics.h

@@ -310,7 +310,7 @@ class AutofillMetrics {

AutofillMetrics();

virtual ~AutofillMetrics();

- virtual void LogCreditCardInfoBarMetric(InfoBarMetric metric) const;

+ static void LogCreditCardInfoBarMetric(InfoBarMetric metric);

virtual void LogDeveloperEngagementMetric(

DeveloperEngagementMetric metric) const;

« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_metrics.cc » ('j') | no next file with comments »