components/autofill/core/browser/autofill_metrics.cc - Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 780423002: Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: static-ify Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_metrics.h ('k') | components/autofill/core/browser/test_autofill_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics.cc

diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc

index c3a271ac617536a764aebff0962bc9fd21e68152..b1ea0d94f5da8017c73a55c52bdd0cf0bcca7aaf 100644

--- a/components/autofill/core/browser/autofill_metrics.cc

+++ b/components/autofill/core/browser/autofill_metrics.cc

@@ -265,7 +265,8 @@ AutofillMetrics::AutofillMetrics() {

AutofillMetrics::~AutofillMetrics() {

}

-void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) const {

+// static

+void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) {

DCHECK_LT(metric, NUM_INFO_BAR_METRICS);

UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardInfoBar", metric,

NUM_INFO_BAR_METRICS);

« no previous file with comments | « components/autofill/core/browser/autofill_metrics.h ('k') | components/autofill/core/browser/test_autofill_client.h » ('j') | no next file with comments »