Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 778003003: List marker pseudo elements. (Closed)

Created:
6 years ago by dsinclair
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, Dominik Röttsches, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1, Tab Atkins
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

List marker pseudo elements. This CL converts list markers to use pseudo elements which are attached into the DOM tree as needed instead of the ad-hoc method of updateListMarkers used previously. The code is currently behind a RuntimeEnabledFeature so we can land this without effecting the current behaviour and then turn on when ready. BUG=370461

Patch Set 1 #

Total comments: 22

Patch Set 2 : #

Patch Set 3 : Lint fixes #

Patch Set 4 : #

Patch Set 5 #

Patch Set 6 : #

Total comments: 18

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : Show usage of subtreeChangedNotification #

Patch Set 10 : #

Total comments: 15

Patch Set 11 : #

Patch Set 12 : Rebase to master #

Patch Set 13 : #

Patch Set 14 : #

Total comments: 76

Patch Set 15 : Rebase to master #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : Rebase to master #

Patch Set 19 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -118 lines) Patch
M LayoutTests/fast/css/001.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/lists/drag-into-marker.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSTestHelper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSTestHelper.cpp View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/RuleSetTest.cpp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/css/html.css View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +10 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +25 lines, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +18 lines, -5 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 1 2 3 4 5 6 7 8 5 chunks +11 lines, -1 line 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/LayoutTreeBuilder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +17 lines, -1 line 0 comments Download
A Source/core/dom/MarkerPseudoElement.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +47 lines, -0 lines 0 comments Download
A Source/core/dom/MarkerPseudoElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +145 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/dom/PseudoElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOListElement.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOListElement.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutListItem.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +7 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 16 chunks +75 lines, -79 lines 0 comments Download
M Source/core/layout/LayoutListMarker.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +18 lines, -13 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObjectChildList.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/layout/TextAutosizer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +13 lines, -0 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyleConstants.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
Julien - ping for review
Drive-by quick review. The direction seems OK. https://codereview.chromium.org/778003003/diff/1/Source/core/css/RuleSetTest.cpp File Source/core/css/RuleSetTest.cpp (right): https://codereview.chromium.org/778003003/diff/1/Source/core/css/RuleSetTest.cpp#newcode59 Source/core/css/RuleSetTest.cpp:59: } Only ...
6 years ago (2014-12-05 19:44:04 UTC) #2
dsinclair
https://codereview.chromium.org/778003003/diff/1/Source/core/css/parser/BisonCSSParser-in.cpp File Source/core/css/parser/BisonCSSParser-in.cpp (right): https://codereview.chromium.org/778003003/diff/1/Source/core/css/parser/BisonCSSParser-in.cpp#newcode315 Source/core/css/parser/BisonCSSParser-in.cpp:315: } On 2014/12/05 19:44:03, Julien Chaffraix - PST wrote: ...
5 years, 11 months ago (2015-01-23 20:46:36 UTC) #3
Julien - ping for review
Another drive by review. I would need to sit down and burn through the logic ...
5 years, 10 months ago (2015-02-04 01:56:34 UTC) #4
dsinclair
https://codereview.chromium.org/778003003/diff/100001/Source/core/css/RuleSetTest.cpp File Source/core/css/RuleSetTest.cpp (right): https://codereview.chromium.org/778003003/diff/100001/Source/core/css/RuleSetTest.cpp#newcode59 Source/core/css/RuleSetTest.cpp:59: } On 2015/02/04 at 01:56:33, Julien Chaffraix - AEST ...
5 years, 10 months ago (2015-02-04 04:41:33 UTC) #5
dsinclair
https://codereview.chromium.org/778003003/diff/100001/Source/core/css/resolver/StyleResolver.cpp File Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/778003003/diff/100001/Source/core/css/resolver/StyleResolver.cpp#newcode756 Source/core/css/resolver/StyleResolver.cpp:756: if (RuntimeEnabledFeatures::listMarkerPseudoElementEnabled() && pseudoId == MARKER && parentRenderer->style()->display() != ...
5 years, 10 months ago (2015-02-04 15:30:59 UTC) #6
esprehn
You need to do this a different way, you're rebuilding inherit style changes and other ...
5 years, 8 months ago (2015-04-20 16:04:08 UTC) #8
dsinclair
On 2015/04/20 at 16:04:08, esprehn wrote: > https://codereview.chromium.org/778003003/diff/180001/Source/core/layout/LayoutListMarker.cpp#newcode1105 > Source/core/layout/LayoutListMarker.cpp:1105: node()->parentElement()->layoutObject()->containingBlock()->updateLogicalWidth(); > You can't update ...
5 years, 8 months ago (2015-04-21 01:14:14 UTC) #9
dsinclair
PTAL. https://codereview.chromium.org/778003003/diff/180001/Source/core/css/parser/BisonCSSParser-in.cpp File Source/core/css/parser/BisonCSSParser-in.cpp (right): https://codereview.chromium.org/778003003/diff/180001/Source/core/css/parser/BisonCSSParser-in.cpp#newcode245 Source/core/css/parser/BisonCSSParser-in.cpp:245: bool BisonCSSParser::isSelectorAllowedInParsingMode(CSSSelector::PseudoType type) On 2015/04/20 at 16:04:08, esprehn ...
5 years, 8 months ago (2015-04-21 20:23:10 UTC) #11
esprehn
How do the default list markers work? ex. <ol> <li> </ol> If I never specify ...
5 years, 8 months ago (2015-04-22 07:45:46 UTC) #13
dsinclair
The default markers were suppose to be done in UA style but I seem to ...
5 years, 8 months ago (2015-04-22 20:00:39 UTC) #14
esprehn
Let's talk about this next week, I'm concerned you're using this system that was designed ...
5 years, 8 months ago (2015-04-22 21:40:09 UTC) #15
dsinclair
On 2015/04/22 at 21:40:09, esprehn wrote: > Let's talk about this next week, I'm concerned ...
5 years, 8 months ago (2015-04-22 23:22:13 UTC) #16
dsinclair
+tabatkins
5 years, 8 months ago (2015-04-22 23:22:38 UTC) #17
esprehn
We should discuss this next week. As currently implemented this is going to make every ...
5 years, 8 months ago (2015-04-23 06:12:42 UTC) #18
esprehn
5 years, 8 months ago (2015-04-23 07:16:28 UTC) #19
Sorry that's every style recalc that modifies the tree, which is initial
page load.  Can you try running the html5-full-render benchmark?

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698