List marker pseudo elements.

Source/core/html/HTMLOListElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 90 matching lines @@
     updateDistribution();
     LayoutListItem::updateItemValuesForOrderedList(this);
 }
 
 void HTMLOListElement::recalculateItemCount()
 {
     m_itemCount = LayoutListItem::itemCountForOrderedList(this);
     m_shouldRecalculateItemCount = false;
 }
 
+void HTMLOListElement::attach(const AttachContext& context)
+{
+    HTMLElement::attach(context);
+
+    if (!RuntimeEnabledFeatures::listMarkerPseudoElementEnabled())
+        return;
+
+    if (!m_isReversed)
+        return;
+
+    // If we're looking at a reversed ordered list we have to recalculate
+    // all of the marker values after everything is inserted. This is because
+    // we built the tree top to bottom, but that means the list item with the
+    // highest value will end up with 1 and we count down from there.
+    updateItemValues();

[esprehn, 2015/04/22 07:45:45]

Why is this needed? All updateItemValues does is:
updateItemValuesForOrderedList

which goes into each list item doing:

    if (!m_hasExplicitValue) {
        m_isValueUpToDate = false;
        if (m_marker)
           
m_marker->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(LayoutInvalidationReason::ListValueChange);
    }

but every list item is brand new, we just attached them, that means they all
need layout already, all need paint invalidation, and the m_isValueUpToDate
field starts as false. So this shouldn't do anything.

[dsinclair, 2015/04/22 20:00:39]

This works fine for lists that aren't reversed. The problem is, with a reversed
list we do something along the lines of:

- add first item, see only one item, set value to 1
- add second item, see previous was 1, set value to 0
- ...

We quickly end up with negative list values. There is logic in
LayoutListItem::updateListMarkerNumbers which tells it to not call updateValue()
if listNode->needsAttach(). Adding this call here means we can do one walk to
update all of the values for reverse lists at the same time and should save the
O(n^2) walk to do it as we attach.

 }
+
+}