List marker pseudo elements.

Source/core/rendering/RenderListMarker.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2010 Daniel Bates (dbates@intudata.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/rendering/RenderListMarker.h"
 
+#include "core/dom/MarkerPseudoElement.h"
 #include "core/fetch/ImageResource.h"
 #include "core/paint/ListMarkerPainter.h"
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderListItem.h"
 #include "core/rendering/TextRunConstructor.h"
 #include "platform/fonts/Font.h"
 #include "wtf/text/StringBuilder.h"
 
 namespace blink {
 
@@ skipping 1002 matching lines @@
         case Georgian:
             return toGeorgian(value);
         case Hebrew:
             return toHebrew(value);
     }
 
     ASSERT_NOT_REACHED();
     return "";
 }
 
+RenderListMarker::RenderListMarker(Element* node, RenderListItem* item)
+    : RenderBox(node)
+    , m_listItem(item)
+{
+    // init RenderObject attributes
+    setInline(true); // our object is Inline
+    setReplaced(true); // pretend to be replaced
+}
+
 RenderListMarker::RenderListMarker(RenderListItem* item)
     : RenderBox(0)
     , m_listItem(item)
 {
     // init RenderObject attributes
     setInline(true);   // our object is Inline
     setReplaced(true); // pretend to be replaced
 }
 
 RenderListMarker::~RenderListMarker()
@@ skipping 571 matching lines @@
     LayoutRect rect(0, root.selectionTop() - location().y(), size().width(), root.selectionHeight());
     mapRectToPaintInvalidationBacking(paintInvalidationContainer, rect, 0);
     // FIXME: groupedMapping() leaks the squashing abstraction.
     if (paintInvalidationContainer->layer()->groupedMapping())
         RenderLayer::mapRectToPaintBackingCoordinates(paintInvalidationContainer, rect);
     return rect;
 }
 
 void RenderListMarker::listItemStyleDidChange()
 {
-    RefPtr<RenderStyle> newStyle = RenderStyle::create();
-    // The marker always inherits from the list item, regardless of where it might end
-    // up (e.g., in some deeply nested line box). See CSS3 spec.
-    newStyle->inheritFrom(m_listItem->style());
-    if (style()) {
-        // Reuse the current margins. Otherwise resetting the margins to initial values
-        // would trigger unnecessary layout.
-        newStyle->setMarginStart(style()->marginStart());
-        newStyle->setMarginEnd(style()->marginRight());
-    }
+    RefPtr<RenderStyle> newStyle = MarkerPseudoElement::styleForListMarkerRenderer(*m_listItem, style());

[Julien - ping for review, 2015/02/04 01:56:34]

styleRef() (and more generally let's use const RenderStyle&)

[dsinclair, 2015/02/04 15:30:59]

Making this a const RenderStyle& is a much larger change as we have to make
anything that calls Element::styleForRenderer take a const RenderStyle&. I think
this should stay until we convert the rest of the code over to const
RenderStyle&.

     setStyle(newStyle.release());
 }
 
 } // namespace blink