chrome/browser/ui/webui/options/sync_setup_handler.cc - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('K') | « chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc

index e73c25d94c0005cb7ec6a5769996aa480a26d99d..1862ca337b6bc12fd072405e533f7c8ed0dd93cf 100644

--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc

@@ -33,6 +33,7 @@

#include "chrome/browser/ui/browser_navigator.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/singleton_tabs.h"

+#include "chrome/browser/ui/sync/one_click_signin_helper.h"

#include "chrome/browser/ui/sync/signin_histogram.h"

#include "chrome/browser/ui/webui/options/options_handlers_helper.h"

#include "chrome/browser/ui/webui/signin/login_ui_service.h"

@@ -511,6 +512,7 @@ void SyncSetupHandler::DisplayGaiaLoginInNewTabOrWindow() {

error_controller->error_account_id());

}

} else {

+ OneClickSigninHelper::LogHistogramSourceValue(signin::SOURCE_SETTINGS);

if (switches::IsNewAvatarMenu() && !force_new_tab) {

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,