Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3785)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
index 6c45aa930b521262efe40300fa50ba94efba540d..33005e63dc1c05efb1d99dcd123c35f67fe8b49b 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
@@ -273,10 +273,7 @@ void InlineLoginHandlerImpl::SetExtraInitParams(base::DictionaryValue& params) {
net::GetValueForKeyInQuery(current_url, "constrained", &is_constrained);
content::WebContentsObserver::Observe(contents);
-
- signin::Source source = signin::GetSourceForPromoURL(current_url);
- OneClickSigninHelper::LogHistogramValue(
- source, one_click_signin::HISTOGRAM_SHOWN);
+ OneClickSigninHelper::LogHistogramValue(one_click_signin::HISTOGRAM_SHOWN);
}
void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {
@@ -333,12 +330,10 @@ void InlineLoginHandlerImpl::CompleteLogin(const base::ListValue* args) {
dict->GetBoolean("chooseWhatToSync", &choose_what_to_sync);
signin::Source source = signin::GetSourceForPromoURL(current_url);
- OneClickSigninHelper::LogHistogramValue(
- source, one_click_signin::HISTOGRAM_ACCEPTED);
+ OneClickSigninHelper::LogHistogramValue(one_click_signin::HISTOGRAM_ACCEPTED);
bool switch_to_advanced =
choose_what_to_sync && (source != signin::SOURCE_SETTINGS);
OneClickSigninHelper::LogHistogramValue(
- source,
switch_to_advanced ? one_click_signin::HISTOGRAM_WITH_ADVANCED :
one_click_signin::HISTOGRAM_WITH_DEFAULTS);

Powered by Google App Engine
This is Rietveld 408576698