Clean up straggler classes to use embedded signin in page in the new profiles world.

chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 776de7045dea6d190713d698fd3029e0823c9bf5..e85870a11b1f685f6b01e0296ee8072d47e0137b 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -17,6 +17,7 @@
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
@@ -241,21 +242,19 @@ class InstalledBubbleContent : public views::View,
   // Implements the views::LinkListener interface.
   void LinkClicked(views::Link* source, int event_flags) override {
     GetWidget()->Close();
-    std::string configure_url;
     if (source == manage_shortcut_) {
-      configure_url = chrome::kChromeUIExtensionsURL;
+      std::string configure_url = chrome::kChromeUIExtensionsURL;
       configure_url += chrome::kExtensionConfigureCommandsSubPage;
+      chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
+          browser_, GURL(configure_url.c_str())));

[Peter Kasting, 2014/12/12 21:43:05]

Remove .c_str() here, since GURL's constructor actually takes a std::string.

[noms (inactive), 2014/12/16 16:55:50]

Done.

+      chrome::Navigate(&params);
     } else if (source == sign_in_link_) {

[Peter Kasting, 2014/12/12 21:43:05]

Nit: While here, I might just do:

  if (source == sign_in_link_) {
    chrome::ShowBrowserSignin(...);
    return;
  }

  DCHECK_EQ(manage_shortcut_, source);
  ...

To get rid of the NOTREACHED(); return;.

[noms (inactive), 2014/12/16 16:55:50]

Done.

-      configure_url = signin::GetPromoURL(
-          signin::SOURCE_EXTENSION_INSTALL_BUBBLE, false).spec();
+      chrome::ShowBrowserSignin(browser_,
+                                signin::SOURCE_EXTENSION_INSTALL_BUBBLE);
     } else {
       NOTREACHED();
       return;
     }
-    chrome::NavigateParams params(
-        chrome::GetSingletonTabNavigateParams(
-            browser_, GURL(configure_url.c_str())));
-    chrome::Navigate(&params);
   }
 
  private: