chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc - Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 777143003: Clean up straggler classes to use embedded signin in page in the new profiles world. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('K') | « chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

index 6f6e53c32315766aafbed87dd3b57c9d252a9bcd..b9795b57c85a863197cf3ee6be9f65c36ae5b30c 100644

--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

@@ -27,6 +27,7 @@

#include "chrome/browser/signin/signin_promo.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_tabstrip.h"

+#include "chrome/browser/ui/chrome_pages.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/grit/generated_resources.h"

@@ -299,13 +300,7 @@ void LocalDiscoveryUIHandler::HandleShowSyncUI(

Browser* browser = chrome::FindBrowserWithWebContents(

web_ui()->GetWebContents());

DCHECK(browser);

- GURL url(signin::GetPromoURL(signin::SOURCE_DEVICES_PAGE,

- true)); // auto close after success.

- browser->OpenURL(

- content::OpenURLParams(url, content::Referrer(), SINGLETON_TAB,

- ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));

+ chrome::ShowBrowserSignin(browser, signin::SOURCE_DEVICES_PAGE);

}

void LocalDiscoveryUIHandler::StartRegisterHTTP(