Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/user_manager/empty_user_info.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc ('K') | « components/search_engines/template_url_parser.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_manager/empty_user_info.cc
diff --git a/components/user_manager/empty_user_info.cc b/components/user_manager/empty_user_info.cc
index f4f3fca68a539acd50df3dbe5b39fa3ebe2d15f1..ab886f179015a84314061afea70a2e6debf7ef6f 100644
--- a/components/user_manager/empty_user_info.cc
+++ b/components/user_manager/empty_user_info.cc
@@ -17,12 +17,12 @@ EmptyUserInfo::~EmptyUserInfo() {
base::string16 EmptyUserInfo::GetDisplayName() const {
NOTIMPLEMENTED();
- return base::UTF8ToUTF16(std::string());
brettw 2014/12/03 21:12:21 This old code is pretty bad.
+ return base::string16();
}
base::string16 EmptyUserInfo::GetGivenName() const {
NOTIMPLEMENTED();
- return base::UTF8ToUTF16(std::string());
+ return base::string16();
}
std::string EmptyUserInfo::GetEmail() const {
« chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc ('K') | « components/search_engines/template_url_parser.cc ('k') | net/base/mime_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698