Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: components/user_manager/empty_user_info.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/user_manager/empty_user_info.h" 5 #include "components/user_manager/empty_user_info.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 9
10 namespace user_manager { 10 namespace user_manager {
11 11
12 EmptyUserInfo::EmptyUserInfo() { 12 EmptyUserInfo::EmptyUserInfo() {
13 } 13 }
14 14
15 EmptyUserInfo::~EmptyUserInfo() { 15 EmptyUserInfo::~EmptyUserInfo() {
16 } 16 }
17 17
18 base::string16 EmptyUserInfo::GetDisplayName() const { 18 base::string16 EmptyUserInfo::GetDisplayName() const {
19 NOTIMPLEMENTED(); 19 NOTIMPLEMENTED();
20 return base::UTF8ToUTF16(std::string()); 20 return base::string16();
brettw 2014/12/03 21:12:21 This old code is pretty bad.
21 } 21 }
22 22
23 base::string16 EmptyUserInfo::GetGivenName() const { 23 base::string16 EmptyUserInfo::GetGivenName() const {
24 NOTIMPLEMENTED(); 24 NOTIMPLEMENTED();
25 return base::UTF8ToUTF16(std::string()); 25 return base::string16();
26 } 26 }
27 27
28 std::string EmptyUserInfo::GetEmail() const { 28 std::string EmptyUserInfo::GetEmail() const {
29 NOTIMPLEMENTED(); 29 NOTIMPLEMENTED();
30 return std::string(); 30 return std::string();
31 } 31 }
32 32
33 std::string EmptyUserInfo::GetUserID() const { 33 std::string EmptyUserInfo::GetUserID() const {
34 NOTIMPLEMENTED(); 34 NOTIMPLEMENTED();
35 return std::string(); 35 return std::string();
36 } 36 }
37 37
38 const gfx::ImageSkia& EmptyUserInfo::GetImage() const { 38 const gfx::ImageSkia& EmptyUserInfo::GetImage() const {
39 NOTIMPLEMENTED(); 39 NOTIMPLEMENTED();
40 // To make the compiler happy. 40 // To make the compiler happy.
41 return null_image_; 41 return null_image_;
42 } 42 }
43 43
44 } // namespace user_manager 44 } // namespace user_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698