components/search_engines/template_url_parser.cc - Issue 776903002: Cleanup: Remove some unneeded string allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_parser.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix win Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_parser.cc

diff --git a/components/search_engines/template_url_parser.cc b/components/search_engines/template_url_parser.cc

index aa0fd46eba223d94f1f47b8f1d4d98739e880f30..14298da11b6b5381db9598403584cf259bf2b487 100644

--- a/components/search_engines/template_url_parser.cc

+++ b/components/search_engines/template_url_parser.cc

@@ -291,7 +291,8 @@ void TemplateURLParsingContext::CharactersImpl(void* ctx,

const xmlChar* ch,

int len) {

reinterpret_cast<TemplateURLParsingContext*>(ctx)->string_ +=

- base::UTF8ToUTF16(std::string(reinterpret_cast<const char*>(ch), len));

+ base::UTF8ToUTF16(

+ base::StringPiece(reinterpret_cast<const char*>(ch), len));

}

TemplateURL* TemplateURLParsingContext::GetTemplateURL(