chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc - Issue 776903002: Cleanup: Remove some unneeded string allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix win Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/rlz/rlz.cc ('k') | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc » ('j') | components/user_manager/empty_user_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

index aa0deb72ba4e097f3f4f13cc49d41253543fa822..8e8cd3040e971aba14db0ea5b0ce8f170c89ca90 100644

--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

@@ -124,8 +124,7 @@ void CollectModuleVerificationData(

ClientIncidentReport_EnvironmentData_Process_ModuleState* module_state =

process->add_module_state();

- module_state->set_name(

- base::WideToUTF8(std::wstring(modules_to_verify[i])));

+ module_state->set_name(base::WideToUTF8(modules_to_verify[i]));

brettw 2014/12/03 21:12:21 Note that this is the same since there's no wide s

// Add 1 to the ModuleState enum to get the corresponding value in the

// protobuf's ModuleState enum.

module_state->set_modified_state(static_cast<