Cleanup: Remove some unneeded string allocations.

chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.h"
 
 #include <windows.h>
 #include <set>
 
 #include "base/i18n/case_conversion.h"
@@ skipping 106 matching lines @@
   for (size_t i = 0; i < num_modules_to_verify; ++i) {
     std::set<std::string> modified_exports;
     int modified = VerifyModule(modules_to_verify[i], &modified_exports);
 
     if (modified == MODULE_STATE_UNMODIFIED)
       continue;
 
     ClientIncidentReport_EnvironmentData_Process_ModuleState* module_state =
         process->add_module_state();
 
-    module_state->set_name(
-        base::WideToUTF8(std::wstring(modules_to_verify[i])));
+    module_state->set_name(base::WideToUTF8(modules_to_verify[i]));

[brettw, 2014/12/03 21:12:21]

Note that this is the same since there's no wide string piece. But in this case
the implicit constructor works and looks cleaner, so this type of change seems
fine.

     // Add 1 to the ModuleState enum to get the corresponding value in the
     // protobuf's ModuleState enum.
     module_state->set_modified_state(static_cast<
         ClientIncidentReport_EnvironmentData_Process_ModuleState_ModifiedState>(
         modified + 1));
     for (std::set<std::string>::iterator it = modified_exports.begin();
          it != modified_exports.end();
          ++it) {
       module_state->add_modified_export(*it);
     }
   }
 }
 
 void CollectPlatformProcessData(
     ClientIncidentReport_EnvironmentData_Process* process) {
   CollectDlls(process);
   RecordLspFeature(process);
   CollectDllBlacklistData(process);
   CollectModuleVerificationData(
       kModulesToVerify, arraysize(kModulesToVerify), process);
 }
 
 }  // namespace safe_browsing