chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc - Issue 776903002: Cleanup: Remove some unneeded string allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix win Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc ('k') | chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc » ('j') | components/user_manager/empty_user_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

index ffe3cee9d97251dabf480ffa61db199634033ac8..cab5b073cced49cc164375fe14ef200c06b71eb6 100644

--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

@@ -207,7 +207,7 @@ TEST(SafeBrowsingEnvironmentDataCollectionWinTest, VerifyLoadedModules) {

// the returned list of modules.

EXPECT_EQ(1, process_report.module_state_size());

- EXPECT_EQ(base::WideToUTF8(std::wstring(safe_browsing::kTestDllNames[0])),

+ EXPECT_EQ(base::WideToUTF8(safe_browsing::kTestDllNames[0]),

process_report.module_state(0).name());

EXPECT_EQ(

safe_browsing::ClientIncidentReport_EnvironmentData_Process_ModuleState::