Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7607)

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
index 63eba96bce6c5ee5f6a9b71e8c2ec56416ab77df..8dd1a0fd5fd6f1e96031523caa0daa4d83c1d163 100644
--- a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
+++ b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
@@ -98,6 +98,7 @@ class FakeEmptyTopSites : public history::TopSites {
// A test-specific field for controlling when most visited callback is run
// after top sites have been requested.
GetMostVisitedURLsCallback mv_callback;
+
protected:
~FakeEmptyTopSites() override {}
};
@@ -108,7 +109,7 @@ void FakeEmptyTopSites::GetMostVisitedURLs(
mv_callback = callback;
}
-} // namespace
+} // namespace
class ZeroSuggestProviderTest : public testing::Test,
@@ -230,7 +231,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedCallback) {
ChromeAutocompleteSchemeClassifier(&profile_));
history::MostVisitedURLList urls;
history::MostVisitedURL url(GURL("http://foo.com/"),
- base::ASCIIToUTF16(std::string("Foo")));
+ base::ASCIIToUTF16("Foo"));
urls.push_back(url);
provider_->Start(input, false);
@@ -263,7 +264,7 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {
ChromeAutocompleteSchemeClassifier(&profile_));
history::MostVisitedURLList urls;
history::MostVisitedURL url(GURL("http://foo.com/"),
- base::ASCIIToUTF16(std::string("Foo")));
+ base::ASCIIToUTF16("Foo"));
urls.push_back(url);
provider_->Start(input, false);

Powered by Google App Engine
This is Rietveld 408576698