chrome/browser/extensions/api/management/chrome_management_api_delegate.cc - Issue 776903002: Cleanup: Remove some unneeded string allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 776903002: Cleanup: Remove some unneeded string allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix win Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider_unittest.cc ('k') | chrome/browser/extensions/external_pref_loader.cc » ('j') | chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

index 881777573a70d98bf9c5d49a38562d683e759127..7dbd5053cc0d06ee82b20ea8c3158caa59df2c82 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

@@ -200,7 +200,7 @@ class ChromeAppForLinkDelegate : public extensions::AppForLinkDelegate {

const GURL& launch_url,

const favicon_base::FaviconImageResult& image_result) {

WebApplicationInfo web_app;

- web_app.title = base::UTF8ToUTF16(std::string(title));

+ web_app.title = base::UTF8ToUTF16(title);

web_app.app_url = launch_url;

if (!image_result.image.IsEmpty()) {