Cleanup: Remove some unneeded string allocations.

chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/zero_suggest_provider.h"
 
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 80 matching lines @@
     return false;
   }
   // content::NotificationObserver:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override {}
 
   // A test-specific field for controlling when most visited callback is run
   // after top sites have been requested.
   GetMostVisitedURLsCallback mv_callback;
+
  protected:
   ~FakeEmptyTopSites() override {}
 };
 
 void FakeEmptyTopSites::GetMostVisitedURLs(
     const GetMostVisitedURLsCallback& callback,
     bool include_forced_urls)  {
   mv_callback = callback;
 }
 
-} // namespace
+}  // namespace
 
 
 class ZeroSuggestProviderTest : public testing::Test,
                                 public AutocompleteProviderListener {
  public:
   ZeroSuggestProviderTest();
 
   void SetUp() override;
   void TearDown() override;
 
@@ skipping 101 matching lines @@
 
   std::string current_url("http://www.foxnews.com/");
   std::string input_url("http://www.cnn.com/");
   AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
                           std::string(), GURL(current_url),
                           metrics::OmniboxEventProto::OTHER, false, false,
                           true, true,
                           ChromeAutocompleteSchemeClassifier(&profile_));
   history::MostVisitedURLList urls;
   history::MostVisitedURL url(GURL("http://foo.com/"),
-                              base::ASCIIToUTF16(std::string("Foo")));
+                              base::ASCIIToUTF16("Foo"));
   urls.push_back(url);
 
   provider_->Start(input, false);
   EXPECT_TRUE(provider_->matches().empty());
   static_cast<FakeEmptyTopSites*>(profile_.GetTopSites())->mv_callback.Run(
       urls);
   // Should have verbatim match + most visited url match.
   EXPECT_EQ(2U, provider_->matches().size());
   provider_->Stop(false);
 
@@ skipping 12 matching lines @@
 
   std::string current_url("http://www.foxnews.com/");
   std::string input_url("http://www.cnn.com/");
   AutocompleteInput input(base::ASCIIToUTF16(input_url), base::string16::npos,
                           std::string(), GURL(current_url),
                           metrics::OmniboxEventProto::OTHER, false, false,
                           true, true,
                           ChromeAutocompleteSchemeClassifier(&profile_));
   history::MostVisitedURLList urls;
   history::MostVisitedURL url(GURL("http://foo.com/"),
-                              base::ASCIIToUTF16(std::string("Foo")));
+                              base::ASCIIToUTF16("Foo"));
   urls.push_back(url);
 
   provider_->Start(input, false);
   EXPECT_TRUE(provider_->matches().empty());
   // Stop() doesn't always get called.
 
   std::string search_url("https://www.google.com/?q=flowers");
   AutocompleteInput srp_input(
       base::ASCIIToUTF16(search_url),
       base::string16::npos,
@@ skipping 130 matching lines @@
 
   base::RunLoop().RunUntilIdle();
 
   // Expect that the matches have been cleared.
   ASSERT_TRUE(provider_->matches().empty());
 
   // Expect the new results have been stored.
   EXPECT_EQ(empty_response,
             prefs->GetString(prefs::kZeroSuggestCachedResults));
 }