Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests (Closed)

Created:
6 years ago by kinuko
Modified:
6 years ago
Reviewers:
falken, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests Unless we really want to wait for onupdate event we can simply use registration.installing in most tests. I left wait_for_update usage() in: - register-same-scope-different-script-url.html - registration-service-worker-attributes.html - unregister-then-register-new-script.html as they appeared that they explicitly want to wait for 'onupdate'. BUG=439365 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186697

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -194 lines) Patch
M LayoutTests/http/tests/local/serviceworker/resources/fetch-request-body-file-iframe.html View 2 chunks +2 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/scope.js View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/activation-after-registration.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/active.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/load-flushed-script.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/postmessage-after-terminate.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/client-focus.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/controller-on-load.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/controller-on-reload.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/extendable-event-async-waituntil.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-body-mixin.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-canvas-tainting.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-csp.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-css-base-url.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-fallback.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-no-freshness-headers.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-resources.html View 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-request-xhr.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-response-xhr.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/indexeddb.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/installing.html View 2 chunks +1 line, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/interfaces.html View 2 chunks +2 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/postmessage-to-client.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-events.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/request-end-to-end.html View 2 chunks +3 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-access-control-util.js View 1 chunk +3 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html View 1 chunk +4 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/state.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-controller.html View 3 chunks +3 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register.html View 4 chunks +4 lines, -16 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html View 5 chunks +5 lines, -20 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/waiting.html View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kinuko
falken@ or nhiroki@: either one of you can review this? (Low priority cleanup patch, based ...
6 years ago (2014-12-05 07:58:45 UTC) #4
falken
lgtm, thanks Now another cleanup task can be removing "wait_for_activated" or simply making it a ...
6 years ago (2014-12-08 02:13:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/776373003/20001
6 years ago (2014-12-08 12:53:58 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-08 12:56:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186697

Powered by Google App Engine
This is Rietveld 408576698