LayoutTests/http/tests/serviceworker/request-end-to-end.html - Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/request-end-to-end.html

Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/registration-events.html ('k') | LayoutTests/http/tests/serviceworker/resources/fetch-access-control-util.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/request-end-to-end.html

diff --git a/LayoutTests/http/tests/serviceworker/request-end-to-end.html b/LayoutTests/http/tests/serviceworker/request-end-to-end.html

index 8e459cf1d14f4520620bd0b656977727a108925d..06fb8b5221f88dc1d8c448e06782c518a601b29e 100644

--- a/LayoutTests/http/tests/serviceworker/request-end-to-end.html

+++ b/LayoutTests/http/tests/serviceworker/request-end-to-end.html

@@ -10,10 +10,7 @@ t.step(function() {

var scope = 'resources/blank.html';

service_worker_unregister_and_register(t, url, scope)

- .then(t.step_func(function(registration) {

- return wait_for_update(t, registration);

- }))

- .then(t.step_func(onUpdateFound))

+ .then(onRegister)

.catch(unreached_rejection(t));

function sendMessagePort(worker) {

@@ -22,7 +19,8 @@ t.step(function() {

return messageChannel.port1;

}

- function onUpdateFound(sw) {

+ function onRegister(registration) {

+ var sw = registration.installing;

var port = sendMessagePort(sw);

port.addEventListener('message', t.step_func(function(event) {

onMessage(event);