Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: LayoutTests/http/tests/serviceworker/interfaces.html

Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/interfaces.html
diff --git a/LayoutTests/http/tests/serviceworker/interfaces.html b/LayoutTests/http/tests/serviceworker/interfaces.html
index 6a82d26a7f7a3ce1613daa80dd76c95f5257731b..7c3a6f1bf6c2af84334e274f1c446330d2442374 100644
--- a/LayoutTests/http/tests/serviceworker/interfaces.html
+++ b/LayoutTests/http/tests/serviceworker/interfaces.html
@@ -18,12 +18,10 @@ test(function() {
async_test(function(t) {
var EVENT_HANDLER = 'object';
var scope = 'resources/scope/interfaces-and-attributes';
- var registration;
service_worker_unregister_and_register(
t, 'resources/empty-worker.js', scope)
- .then(function(r) {
- registration = r;
+ .then(function(registration) {
verify_interface(
'ServiceWorkerRegistration', registration,
{
@@ -34,11 +32,8 @@ async_test(function(t) {
unregister: 'function',
onupdatefound: EVENT_HANDLER
});
- return wait_for_update(t, registration);
- })
- .then(function(worker) {
verify_interface(
- 'ServiceWorker', worker,
+ 'ServiceWorker', registration.installing,
{
scriptURL: 'string',
state: 'string',

Powered by Google App Engine
This is Rietveld 408576698