LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html - Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

Issue 776373003: ServiceWorker cleanup: remove wait_for_update() in favor of r.installing in most tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/fetch-access-control-util.js ('k') | LayoutTests/http/tests/serviceworker/serviceworkerobject-terminate.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

diff --git a/LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html b/LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

index e13505345eb101f41b30114ca94af5041b58d5ae..ab88de16bbe03cfc7f12a9e92a93f38319faa996 100644

--- a/LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

+++ b/LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html

@@ -11,13 +11,11 @@ function url_test(name, url) {

var expectedURL = normalizeURL(url);

service_worker_unregister_and_register(t, url, scope)

.then(function(registration) {

- return wait_for_update(t, registration);

+ var worker = registration.installing;

+ assert_equals(worker.scriptURL, expectedURL,

+ 'Returned ServiceWorker object should have scriptURL');

+ service_worker_unregister_and_done(t, scope);

})

- .then(t.step_func(function(worker) {

- assert_equals(worker.scriptURL, expectedURL,

- 'Returned ServiceWorker object should have scriptURL');

- service_worker_unregister_and_done(t, scope);

- }))

.catch(unreached_rejection(t));

}, 'Verify the scriptURL property: ' + name);

}