Add support for generating an Eclipse .classpath file

Add support for generating an Eclipse .classpath file

This adds support for generating a .classpath file that can be copied
to an Eclipse project for improved symbol navigation.

BUG=gyp:472
r2015

[mckev, 2014-12-06 00:34:02]

mckev@amazon.com changed reviewers:
+ thakis@chromium.org

[mckev, 2014-12-06 00:35:03]

Hi Nico!

PTAL at this small patch for the Eclipse generator.  Please let me know if you'd
like some sample output, I'd be happy to provide it.

Thanks,
Kevin M. McCormick
mckev@amazon.com

[Nico, 2014-12-08 17:59:01]

lgtm, thanks for the patch.

Makes sense, but I'm not familiar with eclipse much. From what I understand,
this generator is unowned (the people who wrote it moved on, and it doesn't have
any tests), so feel free to make it your own :-)

Let me know if you need me to land this for you.

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse.py
File pylib/gyp/generator/eclipse.py (right):

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse....
pylib/gyp/generator/eclipse.py:390: if os.path.splitext(input_)[1] == '.java'
and \
nit: prefer

  if (foo and
      bar):

over

  if foo and \
      bar:

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse....
pylib/gyp/generator/eclipse.py:395: # these are canonical package root names.
this seems a bit fragile (but i can't think of anything better)

[Nico, 2014-12-08 18:00:26]

(also, i didn't get an email review request for this, I just happened to see
this while looking at codereview.chromium.org. To send out a review, first fill
in a reviewer, and then make sure to hit "m" and hit "publish" to send an email
– else the reviewers likely won't know about your patches)

[mckev, 2014-12-09 21:37:11]

On 2014/12/08 18:00:26, Nico wrote:
> (also, i didn't get an email review request for this, I just happened to see
> this while looking at http://codereview.chromium.org. To send out a review,
first fill
> in a reviewer, and then make sure to hit "m" and hit "publish" to send an
email
> – else the reviewers likely won't know about your patches)

Indeed.  We're currently having a problem with notifications from Reitveld that
are from our domain (amazon.com).  They tend to get marked as spam inside of
chromium.org.  If you have any suggestions on how we can engage someone on your
end, feel free to ping me by email.

[mckev, 2014-12-09 21:42:41]

Thanks for the review!

I'm not a committer, so please land this change on my behalf.  Will a change
need to be made in Chromium to pick up this change, or does it roll
occasionally?

Also, once this change lands, then the instructions at
https://code.google.com/p/chromium/wiki/AndroidEclipseDev should be updated to
remove the manually maintained classpath XML, and instead point to the file
generated by GYP.  Can I make that edit, and if so, how?

We might take you up on the offer and make more improvements to this generator
:-)

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse.py
File pylib/gyp/generator/eclipse.py (right):

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse....
pylib/gyp/generator/eclipse.py:390: if os.path.splitext(input_)[1] == '.java'
and \
On 2014/12/08 17:59:00, Nico wrote:
> nit: prefer
> 
>   if (foo and
>       bar):
> 
> over
> 
>   if foo and \
>       bar:

Done.

https://codereview.chromium.org/774693004/diff/1/pylib/gyp/generator/eclipse....
pylib/gyp/generator/eclipse.py:395: # these are canonical package root names.
On 2014/12/08 17:59:00, Nico wrote:
> this seems a bit fragile (but i can't think of anything better)

I agree.  I expanded the comment here to be more explicit about this.  If we
work on this further we'll most certainly refine the logic.

[Nico, 2014-12-12 20:03:44]

Landed in r2015. Very sorry about the delay, I again didn't receive your emails.

You'll need to roll gyp deps in chromium to pick up this change. Here's an
example: https://codereview.chromium.org/736133007

[mckev, 2014-12-12 22:47:02]

On 2014/12/12 20:03:44, Nico wrote:
> Landed in r2015. Very sorry about the delay, I again didn't receive your
emails.
> 
> You'll need to roll gyp deps in chromium to pick up this change. Here's an
> example: https://codereview.chromium.org/736133007

Thanks for landing it, and no worries on the delay.  I was amid testing my
change to perform the roll in Chromium when I discovered an obvious bug with
this change.  I apologize for not noticing it during this CL.  The bug fix is
here:

https://codereview.chromium.org/798133002/

You were certainly correct about the package heuristic being fragile.  I'll look
to improve it in the future. :-)