Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 736133007: roll gyp 1994:2008 (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

roll gyp 1994:2008 0a381c0 ninja/win: Let link-wrapper convert /s to \s in the linker command. by thakis@chromium.org 4621f4d Initialize struct flock for AIX with O_LARGEFILE used by Python. by thakis@chromium.org acf3295 Add back support for /Gv now that gyp-win64 has VS2013 by sbaig1@bloomberg.net 66b3c80 Mechanical changes to cleanup pylint presubmit checks by sbaig1@bloomberg.net fb8a7bd Add support for "else if" in gyp conditions by sbaig1@bloomberg.net 0131ede ninja win: Add msvs emulation for FloatingPointModel by sbaig1@bloomberg.net addc5ea win: Use the _winreg module for registry access by sbaig1@bloomberg.net f1c42f7 Revert r1998, it breaks iOS builds by thakis@chromium.org 9c58d52 Fix dependency broken on mac when building FAT binaries. by thakis@chromium.org cb9f256 ninja win: Don't return unfound VS version, raise instead by sbaig1@bloomberg.net 487c0b6 Set ZERO_AR_DATE=1 when running libtool. by maruel@chromium.org f491c0b msvs: Fix rule dependencies for VS2013 by sbaig1@bloomberg.net 723d919 Switch to 2013 now that it's what's on the bots by scottmg@chromium.org a83e5ac Add indentation offset guess for gyp emacs mode. by thakis@chromium.org BUG=436277 ,... TBR=scottmg@chromium.org Committed: https://crrev.com/1138e11079c582d1a01c8b77b808760c9c0c205c Cr-Commit-Position: refs/heads/master@{#305606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
here comes else-if support!
6 years ago (2014-11-25 01:30:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/736133007/1
6 years ago (2014-11-25 01:33:07 UTC) #4
scottmg
lgtm
6 years ago (2014-11-25 01:37:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-25 08:46:38 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-25 08:47:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1138e11079c582d1a01c8b77b808760c9c0c205c
Cr-Commit-Position: refs/heads/master@{#305606}

Powered by Google App Engine
This is Rietveld 408576698