Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 798133002: Add support for generating an Eclipse .classpath file (bug fix) (Closed)

Created:
6 years ago by mckev
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

Add support for generating an Eclipse .classpath file (bug fix) In r2015, support was added for generating a .classpath file in the Eclipse generator. However, it contained a bug that would add an incorrect directory to the classpath in some circumstances, if the root folder or any of its parents were named 'src' or 'java'. This is due to the heuristic nature of determining Java package root locations. This commit resolves the bug by preventing the heuristic from using the root location, or traversing to any of its ancestors. BUG=gyp:472 r2021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pylib/gyp/generator/eclipse.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mckev
Sample output for Chromium (compare it to: https://code.google.com/p/chromium/wiki/AndroidEclipseDev#Appendix_I:_Eclipse_class_path_file ) <?xml version="1.0"?> <classpath> <classpathentry kind="lib" path="third_party/android_tools/sdk/extras/android/support/v13/android-support-v13.jar"/> ...
6 years ago (2014-12-12 22:48:15 UTC) #2
mckev
Here's the bugfix mentioned in https://codereview.chromium.org/774693004/ This should probably be landed before rolling Chromium to ...
6 years ago (2014-12-12 22:50:36 UTC) #3
Nico
lgtm
5 years, 11 months ago (2015-01-07 23:18:46 UTC) #4
Nico
5 years, 11 months ago (2015-01-07 23:20:44 UTC) #5
Message was sent while issue was closed.
landed in r 2021

Powered by Google App Engine
This is Rietveld 408576698