Issue 7712008: Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists.

Issue 7712008: Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai, commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists. BUG=87839, 30394 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97922

Patch Set 2 : Update gtest_exclude #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -38 lines)			Patch
M	chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm	View		2 chunks	+2 lines, -2 lines	1 comment	Download
M	chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm	View		1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm	View		3 chunks	+2 lines, -8 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/7712008/diff/2002/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm File chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm (left): http://codereview.chromium.org/7712008/diff/2002/chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm#oldcode201 chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm:201: [NSDate dateWithTimeIntervalSinceNow:0.1]]; ha.

9 years, 4 months ago (2011-08-22 19:44:57 UTC) #2

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

9 years, 4 months ago (2011-08-23 04:32:05 UTC) #3

commit-bot: I haz the power

9 years, 4 months ago (2011-08-23 20:15:41 UTC) #4

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 97885, job name
was 7712008-2002 (retry) (retry) (previous was lost) (previous was lost).

Expand Messages | Collapse Messages