Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists.

chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h"
 
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 149 matching lines @@
 
     // The zoom buttons should not close the menu if opened sticky.
     if ([sender respondsToSelector:@selector(isTracking)] &&
         [sender performSelector:@selector(isTracking)]) {
       [menu_ cancelTracking];
     }
   } else {
     // The custom views within the Wrench menu are abnormal and keep the menu
     // open after a target-action.  Close the menu manually.
     [menu_ cancelTracking];
-    [self dispatchCommandInternal:tag];
+
+    // Executing certain commands from the nested run loop of the menu can lead
+    // to wonky behavior (e.g. http://crbug.com/49716). To avoid this, schedule
+    // the dispatch on the outermost run loop.
+    [self performSelector:@selector(performCommandDispatch:)
+               withObject:[NSNumber numberWithInt:tag]
+               afterDelay:0.0];
   }
 }
 
-- (void)dispatchCommandInternal:(NSInteger)tag {
-  // Executing certain commands from the nested run loop of the menu can lead
-  // to wonky behavior (e.g. http://crbug.com/49716). To avoid this, schedule
-  // the dispatch on the outermost run loop.
-  [self performSelector:@selector(performCommandDispatch:)
-             withObject:[NSNumber numberWithInt:tag]
-             afterDelay:0.0];
-}
-
 // Used to perform the actual dispatch on the outermost runloop.
 - (void)performCommandDispatch:(NSNumber*)tag {
   [self wrenchMenuModel]->ExecuteCommand([tag intValue]);
 }
 
 - (WrenchMenuModel*)wrenchMenuModel {
   return static_cast<WrenchMenuModel*>(model_);
 }
 
 // Fit the localized strings into the Cut/Copy/Paste control, then resize the
@@ skipping 37 matching lines @@
   parentFrame.size.width += delta;
   parentFrame.origin.x -= delta;
   [[editCut_ superview] setFrame:parentFrame];
 }
 
 - (NSButton*)zoomDisplay {
   return zoomDisplay_;
 }
 
 @end  // @implementation WrenchMenuController