chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h - Issue 7712008: Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h

Issue 7712008: Refactor and clean up code now that chrome::testing::NSRunLoopRunAllPending() exists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update gtest_exclude Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm ('K') | « chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h

diff --git a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h

index b39e0eb5ed41a4664f7ad528bd22b297b1d8a9f8..d44d83b413739cdc9e20cef29195c71936426130 100644

--- a/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h

+++ b/chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h

@@ -61,14 +61,4 @@ class ZoomLevelObserver;

////////////////////////////////////////////////////////////////////////////////

-@interface WrenchMenuController (UnitTesting)

-// |-dispatchWrenchMenuCommand:| calls this after it has determined the tag of

-// the sender. The default implementation executes the command on the outermost

-// run loop using |-performSelector...withDelay:|. This is not desirable in

-// unit tests because it's hard to test around run loops in a deterministic

-// manner. To avoid those headaches, tests should provide an alternative

-// implementation.

-- (void)dispatchCommandInternal:(NSInteger)tag;

-@end

#endif // CHROME_BROWSER_UI_COCOA_WRENCH_MENU_WRENCH_MENU_CONTROLLER_H_