Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 770703002: Bump min picture version. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Bump min picture version. Chrome Stable is M39, which produces picture format v35: https://chromium.googlesource.com/skia/+/chrome/m39/include/core/SkPicture.h We don't need any code to deal with pictures older than v35. (When M40 goes stable, we can step up to v37, the current latest version.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/88fd0fbcccea615f2d2cd61a121ac9e3185adfe4

Patch Set 1 #

Patch Set 2 : TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -197 lines) Patch
M include/core/SkPicture.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFlattenable.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPaint.cpp View 4 chunks +4 lines, -49 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +5 lines, -30 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M src/core/SkReadBuffer.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +2 lines, -11 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 3 chunks +6 lines, -25 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +7 lines, -20 lines 0 comments Download
M tools/skpinfo.cpp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years ago (2014-12-01 04:02:29 UTC) #2
reed1
wow does that feel good. Going forward, perhaps we should deliberately archive a suite of ...
6 years ago (2014-12-01 14:13:31 UTC) #3
reed1
lgtm
6 years ago (2014-12-01 14:14:13 UTC) #4
mtklein
On 2014/12/01 14:14:13, reed1 wrote: > lgtm I believe we have every iteration of our ...
6 years ago (2014-12-01 14:45:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/770703002/20001
6 years ago (2014-12-01 14:46:40 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 14:56:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/88fd0fbcccea615f2d2cd61a121ac9e3185adfe4

Powered by Google App Engine
This is Rietveld 408576698