Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 769733003: Do not embed constant functions in StoreTransition stub. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
Igor Sheludko, ishell
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Do not embed constant functions in StoreTransition stub. BUG=v8:3629 LOG=N

Patch Set 1 #

Patch Set 2 : Address comments, add ports #

Patch Set 3 : Check that registers do not overlap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -21 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL, if it looks all right, I'll upload other ports.
6 years ago (2014-12-09 10:57:21 UTC) #2
ulan
As discussed offline, I removed the second version of GenerateConstantCheck and added ports.
6 years ago (2014-12-09 11:55:56 UTC) #3
Igor Sheludko
lgtm
6 years ago (2014-12-09 12:56:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769733003/20001
6 years ago (2014-12-09 12:59:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769733003/40001
6 years ago (2014-12-09 13:25:53 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-09 15:11:10 UTC) #11
Yang
6 years ago (2014-12-09 16:08:26 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/785253002/ by yangguo@chromium.org.

The reason for reverting is: GC stress failure:
http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress%20-%201....

Powered by Google App Engine
This is Rietveld 408576698