Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 769733003: Do not embed constant functions in StoreTransition stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Check that registers do not overlap Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 DCHECK(!map_reg.is(scratch)); 325 DCHECK(!map_reg.is(scratch));
326 __ LoadWeakValue(map_reg, cell, miss); 326 __ LoadWeakValue(map_reg, cell, miss);
327 if (transition->CanBeDeprecated()) { 327 if (transition->CanBeDeprecated()) {
328 __ lw(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset)); 328 __ lw(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset));
329 __ And(at, scratch, Operand(Map::Deprecated::kMask)); 329 __ And(at, scratch, Operand(Map::Deprecated::kMask));
330 __ Branch(miss, ne, at, Operand(zero_reg)); 330 __ Branch(miss, ne, at, Operand(zero_reg));
331 } 331 }
332 } 332 }
333 333
334 334
335 void NamedStoreHandlerCompiler::GenerateConstantCheck(Object* constant, 335 void NamedStoreHandlerCompiler::GenerateConstantCheck(Register map_reg,
336 int descriptor,
336 Register value_reg, 337 Register value_reg,
338 Register scratch,
337 Label* miss_label) { 339 Label* miss_label) {
338 __ li(scratch1(), handle(constant, isolate())); 340 DCHECK(!map_reg.is(scratch));
339 __ Branch(miss_label, ne, value_reg, Operand(scratch1())); 341 DCHECK(!map_reg.is(value_reg));
342 DCHECK(!value_reg.is(scratch));
343 __ LoadInstanceDescriptors(map_reg, scratch);
344 __ lw(scratch,
345 FieldMemOperand(scratch, DescriptorArray::GetValueOffset(descriptor)));
346 __ Branch(miss_label, ne, value_reg, Operand(scratch));
340 } 347 }
341 348
342 349
343 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type, 350 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type,
344 Register value_reg, 351 Register value_reg,
345 Label* miss_label) { 352 Label* miss_label) {
346 __ JumpIfSmi(value_reg, miss_label); 353 __ JumpIfSmi(value_reg, miss_label);
347 HeapType::Iterator<Map> it = field_type->Classes(); 354 HeapType::Iterator<Map> it = field_type->Classes();
348 if (!it.Done()) { 355 if (!it.Done()) {
349 __ lw(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset)); 356 __ lw(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset));
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 // Return the generated code. 691 // Return the generated code.
685 return GetCode(kind(), Code::NORMAL, name); 692 return GetCode(kind(), Code::NORMAL, name);
686 } 693 }
687 694
688 695
689 #undef __ 696 #undef __
690 } 697 }
691 } // namespace v8::internal 698 } // namespace v8::internal
692 699
693 #endif // V8_TARGET_ARCH_MIPS 700 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698