src/ic/handler-compiler.h - Issue 769733003: Do not embed constant functions in StoreTransition stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.h

Issue 769733003: Do not embed constant functions in StoreTransition stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Check that registers do not overlap Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.h

diff --git a/src/ic/handler-compiler.h b/src/ic/handler-compiler.h

index ec07572fe563d82a9198990914dfb13f17f822b1..efb0a397c877e5f0cc28f35851dc0dca8e68a46a 100644

--- a/src/ic/handler-compiler.h

+++ b/src/ic/handler-compiler.h

@@ -234,7 +234,8 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {

void GenerateRestoreMap(Handle<Map> transition, Register scratch,

Label* miss);

- void GenerateConstantCheck(Object* constant, Register value_reg,

+ void GenerateConstantCheck(Register map_reg, int descriptor,

+ Register value_reg, Register scratch,

Label* miss_label);

void GenerateFieldTypeChecks(HeapType* field_type, Register value_reg,

« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »