Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Side by Side Diff: src/ic/mips64/handler-compiler-mips64.cc

Issue 769733003: Do not embed constant functions in StoreTransition stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Check that registers do not overlap Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 DCHECK(!map_reg.is(scratch)); 326 DCHECK(!map_reg.is(scratch));
327 __ LoadWeakValue(map_reg, cell, miss); 327 __ LoadWeakValue(map_reg, cell, miss);
328 if (transition->CanBeDeprecated()) { 328 if (transition->CanBeDeprecated()) {
329 __ ld(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset)); 329 __ ld(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset));
330 __ And(at, scratch, Operand(Map::Deprecated::kMask)); 330 __ And(at, scratch, Operand(Map::Deprecated::kMask));
331 __ Branch(miss, ne, at, Operand(zero_reg)); 331 __ Branch(miss, ne, at, Operand(zero_reg));
332 } 332 }
333 } 333 }
334 334
335 335
336 void NamedStoreHandlerCompiler::GenerateConstantCheck(Object* constant, 336 void NamedStoreHandlerCompiler::GenerateConstantCheck(Register map_reg,
337 int descriptor,
337 Register value_reg, 338 Register value_reg,
339 Register scratch,
338 Label* miss_label) { 340 Label* miss_label) {
339 __ li(scratch1(), handle(constant, isolate())); 341 DCHECK(!map_reg.is(scratch));
340 __ Branch(miss_label, ne, value_reg, Operand(scratch1())); 342 DCHECK(!map_reg.is(value_reg));
343 DCHECK(!value_reg.is(scratch));
344 __ LoadInstanceDescriptors(map_reg, scratch);
345 __ ld(scratch,
346 FieldMemOperand(scratch, DescriptorArray::GetValueOffset(descriptor)));
347 __ Branch(miss_label, ne, value_reg, Operand(scratch));
341 } 348 }
342 349
343 350
344 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type, 351 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type,
345 Register value_reg, 352 Register value_reg,
346 Label* miss_label) { 353 Label* miss_label) {
347 __ JumpIfSmi(value_reg, miss_label); 354 __ JumpIfSmi(value_reg, miss_label);
348 HeapType::Iterator<Map> it = field_type->Classes(); 355 HeapType::Iterator<Map> it = field_type->Classes();
349 if (!it.Done()) { 356 if (!it.Done()) {
350 __ ld(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset)); 357 __ ld(scratch1(), FieldMemOperand(value_reg, HeapObject::kMapOffset));
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 // Return the generated code. 692 // Return the generated code.
686 return GetCode(kind(), Code::NORMAL, name); 693 return GetCode(kind(), Code::NORMAL, name);
687 } 694 }
688 695
689 696
690 #undef __ 697 #undef __
691 } 698 }
692 } // namespace v8::internal 699 } // namespace v8::internal
693 700
694 #endif // V8_TARGET_ARCH_MIPS64 701 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips/handler-compiler-mips.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698