Remove FlowThreadController and relateds.

Remove FlowThreadController and relateds.

There's no need for FlowThreadController,
CurrentRenderFlowThreadMaintainer or CurrentRenderFlowThreadDisabler.

Store the current flow thread in LayoutState instead, so that
RenderObject::locateFlowThreadContainingBlock() can still find the
flow thread quickly during layout.

Also removed CSS regions relic from collapseAnonymousBlockChild().

R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186328

[Julien - ping for review, 2014-12-02 16:59:47]

lgtm

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/La...
File Source/core/rendering/LayoutState.h (right):

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/La...
Source/core/rendering/LayoutState.h:91: RenderFlowThread* m_flowThread;
Maybe we should add the field to PaintInvalidationState too as we need to know
the flow thread to generate paint invalidations. This is a separate patch
though.

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderView.cpp (right):

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderView.cpp:844: RenderFlowThread* currentFlowThread =
m_layoutState->flowThread();
We could potentially combine the lines below:

if (RenderFlowThread* currentFlowThread = m_layoutState->flowThread())
    currentFlowThread->popFlowThreadLayoutState();
m_layoutState = m_layoutState->next();

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderView.cpp:846: if (currentFlowThread)
Nit: /me prefers early returns

[mstensho (USE GERRIT), 2014-12-02 19:41:12]

Not addressing any of the nits, since this is code that I'm about to kill anyway
(and I have the patch ready, so this way I'll save myself from some conflict
resolution) :)

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/La...
File Source/core/rendering/LayoutState.h (right):

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/La...
Source/core/rendering/LayoutState.h:91: RenderFlowThread* m_flowThread;
On 2014/12/02 16:59:47, Julien Chaffraix - PST wrote:
> Maybe we should add the field to PaintInvalidationState too as we need to know
> the flow thread to generate paint invalidations. This is a separate patch
> though.

Do you have a bug report on that? I think paint invalidations generally work
fine already.

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderView.cpp (right):

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderView.cpp:844: RenderFlowThread* currentFlowThread =
m_layoutState->flowThread();
On 2014/12/02 16:59:47, Julien Chaffraix - PST wrote:
> We could potentially combine the lines below:
> 
> if (RenderFlowThread* currentFlowThread = m_layoutState->flowThread())
>     currentFlowThread->popFlowThreadLayoutState();
> m_layoutState = m_layoutState->next();

That may be right, but never mind: I have another upcoming patch that kills all
this code. :)

https://codereview.chromium.org/769093002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderView.cpp:846: if (currentFlowThread)
On 2014/12/02 16:59:47, Julien Chaffraix - PST wrote:
> Nit: /me prefers early returns

Ditto.

[mstensho (USE GERRIT), 2014-12-02 19:41:19]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-12-02 19:42:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/769093002/20001

[commit-bot: I haz the power, 2014-12-02 19:55:46]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186328