Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 766653008: Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferFactorySolo
Project:
skia
Visibility:
Public.

Description

Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory. (patchset #7 id:140001 of https://codereview.chromium.org/759713002/) Reason for revert: break many gm's Original issue's description: > Make all blending up to GrOptDrawState be handled by the xp/xp factory. > > In this cl the blending information is extracted for the xp and stored in the ODS > which is then used as it currently is. In the follow up cl, an XP backend will be added > and at that point all blending work will take place inside XP's. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7c66342a399b529634bed0fabfaa562db2c0dbd4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8d95ffa497091d0c9c7cda099684c7bca6714a17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -632 lines) Patch
M gm/texdata.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/gpu/GrPaint.h View 7 chunks +22 lines, -10 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 4 chunks +1 line, -110 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 4 chunks +9 lines, -41 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/GrDrawState.h View 5 chunks +91 lines, -18 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 11 chunks +150 lines, -21 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 9 chunks +81 lines, -69 lines 0 comments Download
M src/gpu/GrPaint.cpp View 2 chunks +57 lines, -3 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 4 chunks +1 line, -10 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 4 chunks +5 lines, -15 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 5 chunks +7 lines, -293 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Make all blending up to GrOptDrawState be handled by the xp/xp factory.
6 years ago (2014-12-08 21:25:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766653008/1
6 years ago (2014-12-08 21:26:26 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-08 21:26:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d95ffa497091d0c9c7cda099684c7bca6714a17

Powered by Google App Engine
This is Rietveld 408576698